frontpage.
newsnewestaskshowjobs

Made with ♥ by @iamnishanth

Open Source @Github

fp.

Open in hackernews

Ask HN: Etiquette giving feedback on mostly AI-generated PRs from co-workers

4•chfritz•14h ago
I struggle to find the right way to provide feedback on pull requests (PRs) that mostly consist of AI generated code. Co-workers submitting them have learned to disclose this -- I found it frustrating when they didn't -- and now say they have reviewed and iterated on it. But often the result is still what I would describe as "a big contribution off the mark", meaning a lot of code that just follows the wrong approach.

Usually, when someone does a lot of work, which we used to be able to measure in lines of code, it would seem unfair to criticize them afterwards. A good development process with ticket discussions would ensure that someone doesn't do a lot of work before there is agreement on the general approach. But now, with AI, this script no longer works, partially because it's "too easy" to do it before even deciding this.

So I'm asking myself and now HN: is it OK to point out when an entire PR as such is garbage and should simply be discarded? How can I tell how much "brain juice" a co-worker has spent on it and how attached they might be to it by now if I don't even know whether they even know the code they submitted or not?

I have to admit that I hate reviewing huge PRs and the problem with AI generated code is that often it would have been much better to find and use an existing open-source library to get the task done rather than (re-)generate a lot of code for it. But how will I know this until I've actually taken the time to review and understand the big, new proposed contributions? And even if I now do spend the time to actually understand the code and implied approach, how will I know which part of it reflects their genuine opinion and intellect (which I'd be hesitant to criticize) and what is AI-fluff I can rip apart without stepping on their toes? If the answer is "let's have a meeting", then I'd say the process has failed.

Not sure there is a right answer here, but I would love to hear people's take on this.

Comments

Webstir•13h ago
Here's a take: Consider a new job that doesn't involve (A)uto(I)nfantillization. You're destroying humanity.
wertnayi•13h ago
Some options:

1. "Your PR is bad and you should feel bad"

2. Use AI to reject the PR

3. Does it fill an immediate business need? Then Ship it. Most code is slop anyways, even before AI era. Otherwise, it's an unjustified continuous maintenance burden - drop it.

Remember all your competitors are also using AI slop. You're in good company...

dsernst•13h ago
> which part of it reflects their genuine opinion and intellect (which I'd be hesitant to criticize) and what is AI-fluff I can rip apart without stepping on their toes?

Are you able to ask them this directly? They might appreciate it.

everybodyknows•12h ago
Why not demand that code be accompanied by comments that describe the solution at a higher level of design abstraction? Perhaps also a justification of design choices, and comparison with similar implementations in off-the-shelf libraries?

Ask HN: Those making $500/month on side projects in 2025 – Show and tell

370•cvbox•16h ago•403 comments

Is analytics a necessary evil rather than a real value driver?

5•tiazm•38m ago•2 comments

Tell HN: HN was down

588•uyzstvqs•1d ago•319 comments

Ask HN: How to fight back against Lovable, Replit, etc. in enterprise products

2•bears123•56m ago•1 comments

Ask HN: Does anyone understand how Hacker News works?

140•jannesblobel•18h ago•180 comments

Ask HN: Should I Open Source Every Product I Build as an Indie Developer?

6•tomfox2•2h ago•4 comments

Ask HN: If you had to get a non-tech masters degree, what would you go for?

2•highwayman47•2h ago•3 comments

Ask HN: What Are You Working On? (December 2025)

437•david927•4d ago•1430 comments

Ask HN: Why do official-looking emails cause anxiety before I read them?

4•BianDan•4h ago•4 comments

Tell HN: AI coding is sexy, but accounting is the real low-hanging target

61•bmadduma•6d ago•55 comments

Ask HN: Decentralized Auth for Information Exchange?

2•vxsz•8h ago•2 comments

Ask HN: Etiquette giving feedback on mostly AI-generated PRs from co-workers

4•chfritz•14h ago•4 comments

Ask HN: Should I start a software foundation (goal: help emergency services)?

9•strgcmc•18h ago•0 comments

Ask HN: Is RSS Still Alive?

6•militanz•10h ago•10 comments

FWS – pip-installable embedded process supervisor with PTY/pipe/dtach back ends

2•mrsurge•11h ago•0 comments

Ask HN: Is starting a personal blog still worth it in the age of AI?

62•nazarh•3d ago•75 comments

Ask HN: Is building a calm, non-gamified learning app a mistake?

86•hussein-khalil•3d ago•122 comments

Computer animator and Amiga fanatic Dick van Dyke turns 100

280•ggm•5d ago•92 comments

Ask HN: What are your predictions for 2026?

24•mfrw•1d ago•20 comments

Ask HN: How can I get better at using AI for programming?

466•lemonlime227•5d ago•466 comments

Memory Safety in C# vs. Rust

14•northlondoner•2d ago•12 comments

Ask HN: How are you vibe coding in an established code base?

10•adam_gyroscope•1d ago•7 comments

Ask HN: Was HN just down for anyone else?

84•rozenmd•1d ago•2 comments

Ask HN: Claude Opus 4.5 vs. GPT 5.1 Codex Max for coding. Worth the upgrade?

5•terabytest•2d ago•6 comments

Ask HN: Bloggers, how do you manage your content?

11•freemanjiang•2d ago•14 comments

Who has enjoyed using PR code reviewers? What worked and what didn’t?

3•yashwantphogat•1d ago•4 comments

Ask HN: Did anyone else notice that the OpenAI Labs website was completely gone?

27•underlipton•5d ago•9 comments

Ask HN: Thought-Provoking Books

21•Agraillo•5d ago•18 comments

Ask HN: Best back end to run models on Google TPU?

8•vood•3d ago•0 comments

You've reached the end!