frontpage.
newsnewestaskshowjobs

Made with ♥ by @iamnishanth

Open Source @Github

fp.

Open in hackernews

Ask HN: Etiquette giving feedback on mostly AI-generated PRs from co-workers

2•chfritz•10h ago
I struggle to find the right way to provide feedback on pull requests (PRs) that mostly consist of AI generated code. Co-workers submitting them have learned to disclose this -- I found it frustrating when they didn't -- and now say they have reviewed and iterated on it. But often the result is still what I would describe as "a big contribution off the mark", meaning a lot of code that just follows the wrong approach.

Usually, when someone does a lot of work, which we used to be able to measure in lines of code, it would seem unfair to criticize them afterwards. A good development process with ticket discussions would ensure that someone doesn't do a lot of work before there is agreement on the general approach. But now, with AI, this script no longer works, partially because it's "too easy" to do it before even deciding this.

So I'm asking myself and now HN: is it OK to point out when an entire PR as such is garbage and should simply be discarded? How can I tell how much "brain juice" a co-worker has spent on it and how attached they might be to it by now if I don't even know whether they even know the code they submitted or not?

I have to admit that I hate reviewing huge PRs and the problem with AI generated code is that often it would have been much better to find and use an existing open-source library to get the task done rather than (re-)generate a lot of code for it. But how will I know this until I've actually taken the time to review and understand the big, new proposed contributions? And even if I now do spend the time to actually understand the code and implied approach, how will I know which part of it reflects their genuine opinion and intellect (which I'd be hesitant to criticize) and what is AI-fluff I can rip apart without stepping on their toes? If the answer is "let's have a meeting", then I'd say the process has failed.

Not sure there is a right answer here, but I would love to hear people's take on this.

Comments

Webstir•10h ago
Here's a take: Consider a new job that doesn't involve (A)uto(I)nfantillization. You're destroying humanity.
wertnayi•10h ago
Some options:

1. "Your PR is bad and you should feel bad"

2. Use AI to reject the PR

3. Does it fill an immediate business need? Then Ship it. Most code is slop anyways, even before AI era. Otherwise, it's an unjustified continuous maintenance burden - drop it.

Remember all your competitors are also using AI slop. You're in good company...

dsernst•9h ago
> which part of it reflects their genuine opinion and intellect (which I'd be hesitant to criticize) and what is AI-fluff I can rip apart without stepping on their toes?

Are you able to ask them this directly? They might appreciate it.

everybodyknows•8h ago
Why not demand that code be accompanied by comments that describe the solution at a higher level of design abstraction? Perhaps also a justification of design choices, and comparison with similar implementations in off-the-shelf libraries?

Experts Say Even Average Venezuelans Critical of Maduro Won't Back Regime Change

https://truthout.org/articles/experts-say-even-average-venezuelans-critical-of-maduro-wont-back-r...
1•robtherobber•18s ago•0 comments

Show HN: HN Wrapped 2025 – your year on Hacker News

https://hn-wrapped.kadoa.com?year=2025
1•hubraumhugo•19s ago•0 comments

Are Apple Gift Cards Safe to Redeem?

https://daringfireball.net/linked/2025/12/17/are-apple-gift-cards-safe-to-redeem
1•tosh•55s ago•0 comments

Running a full voice stack (ASR –> LLM –> TTS) locally with Docker

https://www.docker.com/blog/develop-deploy-voice-ai-apps/
1•3Sophons•2m ago•1 comments

systemd v259 Released

https://github.com/systemd/systemd/releases/tag/v259
1•voxadam•3m ago•0 comments

Engineering dogmas it's time to retire

https://newsletter.manager.dev/p/5-engineering-dogmas-its-time-to
1•flail•4m ago•0 comments

Ask HN: How are you building a company-wide MCP strategy?

1•shouche•5m ago•1 comments

Hatred of Israel Caused Iran's Water Crisis

https://aish.com/hatred-of-israel-caused-irans-water-crisis/
1•mhb•6m ago•1 comments

Show HN: Physically Based Shading Dojo in WebGL2

https://gnikoloff.github.io/webgl-pbr-dojo/
1•georginikolov•7m ago•1 comments

Legal AI startups sell fear, not products

https://theredline.versionstory.com/p/why-cant-43b-in-legal-ai-investment
1•jpbryan•7m ago•0 comments

How to Win Titular Metagames

https://taylor.town/how-to-title
1•surprisetalk•8m ago•0 comments

Please Just Try Htmx

http://pleasejusttryhtmx.com/
2•iNic•9m ago•0 comments

Ask HN: How to manage inbound calls/ emails/ texts etc.

1•duckkg5•9m ago•1 comments

The collab way for creators to find work and get paid

https://the-fuse.app/
1•iCeGaming•9m ago•1 comments

How agent workloads change the shape of data systems

https://tonbo.io/blog/tonbo-manifesto
1•ethegwo•11m ago•0 comments

Free Live Streaming Platform for Developers with No Catches

https://www.red5.net/blog/free-live-streaming-platform-for-developers/
1•mondainx•12m ago•1 comments

Show HN: SHM – Telemetry for self-hosted apps (no user tracking)

https://github.com/btouchard/shm
1•benjy3379•14m ago•0 comments

1.5 TB of VRAM on Mac Studio – RDMA over Thunderbolt 5

https://www.jeffgeerling.com/blog/2025/15-tb-vram-on-mac-studio-rdma-over-thunderbolt-5
2•bonyt•15m ago•0 comments

Trump Media is merging with a nuclear fusion company

https://www.theverge.com/news/847159/trump-media-tae-technologies-merger-nuclear-fusion
2•trueduke•16m ago•0 comments

Pandemic Lockdowns Changed a Songbird's Beak

https://www.nytimes.com/2025/12/15/science/covid-ecology-anthropause-birds.html
1•danso•17m ago•1 comments

MEV is an execution design problem

1•shdwapp•18m ago•0 comments

Jensen Huang: Israel has become Nvidia's second home

https://en.globes.co.il/en/article-jensen-huang-israel-has-become-nvidias-second-home-1001529537
1•mhb•19m ago•0 comments

Show HN: Open-Source B2B SaaS Starter Kit (Go, Next.js, RBAC, Polar)

https://github.com/moasq/production-saas-starter
1•moh_quz•19m ago•0 comments

The Impact of Technical Blogging

https://writethatblog.substack.com/p/the-impact-of-technical-blogging
1•cyndunlop•19m ago•0 comments

An Engineer's Critique of Physicalism (Materialism)

https://arrno.substack.com/p/an-engineers-critique-of-physicalism
1•arrno•19m ago•1 comments

Closure of Operations in Computer Programming

https://deniskyashif.com/2025/12/18/closure-of-operations-in-computer-programming/
1•deniskyashif•20m ago•0 comments

The Mysterious Forces Steering Views on Hacker News

https://xn--gckvb8fzb.com/the-mysterious-forces-steering-views-on-hacker-news/
3•dxs•22m ago•1 comments

The 10 Most Mind-Blowing Discoveries About the Brain in 2025

https://www.scientificamerican.com/article/10-mind-blowing-brain-discoveries-from-2025/
1•dxs•23m ago•0 comments

Virtualizing Nvidia HGX B200 GPUs with Open Source

https://www.ubicloud.com/blog/virtualizing-nvidia-hgx-b200-gpus-with-open-source
16•ben_s•23m ago•0 comments

Programming Ruby 4 (The 6th edition of the PickAxe Book)

https://pragprog.com/titles/ruby6/programming-ruby-4-6th-edition/
1•Kerrick•23m ago•0 comments